Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark wrapped intrinsics as inline(always) #113194

Merged
merged 1 commit into from
Jul 1, 2023
Merged

Mark wrapped intrinsics as inline(always) #113194

merged 1 commit into from
Jul 1, 2023

Conversation

lu-zero
Copy link
Contributor

@lu-zero lu-zero commented Jun 30, 2023

This should mitigate having the inliner decide not to inline when the architecture is lacking an implementation of
TargetTransformInfo::areInlineCompatible aware of the target features (e.g. PowerPC as today).

See rust-lang/stdarch#1443 (comment)

@lu-zero
Mark wrapped intrinsics as inline(always)
528f11c 
This should mitigate having the inliner decide not to inline when
the architecture is lacking an implementation of
TargetTransformInfo::areInlineCompatible aware of the target
features (e.g. PowerPC as today).
@rustbot
Copy link
Collaborator

rustbot commented Jun 30, 2023

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 30, 2023
@Amanieu
Copy link
Member

Amanieu commented Jun 30, 2023

Just to check if this doesn't regress debug build performance.

@bors try @rust-timer perf

@bors
Copy link
Contributor

bors commented Jun 30, 2023

⌛ Trying commit 528f11c with merge 3feb5a8b121d0db15dd937cc048cedd92761655c...

@bors
Copy link
Contributor

bors commented Jun 30, 2023

☀️ Try build successful - checks-actions
Build commit: 3feb5a8b121d0db15dd937cc048cedd92761655c (3feb5a8b121d0db15dd937cc048cedd92761655c)

@Amanieu
Copy link
Member

Amanieu commented Jul 1, 2023

@rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 1, 2023
@lqd
Copy link
Member

lqd commented Jul 1, 2023

@rust-timer build 3feb5a8b121d0db15dd937cc048cedd92761655c

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3feb5a8b121d0db15dd937cc048cedd92761655c): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.6% [0.5%, 3.1%] 4
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.8% [-1.0%, -0.6%] 2
Improvements ✅
(secondary)		 -1.6% [-1.6%, -1.6%] 1
All ❌✅ (primary) 0.8% [-1.0%, 3.1%] 6

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.4% [2.4%, 2.4%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.4% [-0.4%, -0.4%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.0% [-0.4%, 2.4%] 2

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.0% [0.0%, 0.0%] 5
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.1% [-0.2%, -0.0%] 12
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.1% [-0.2%, 0.0%] 17

Bootstrap: 660.64s -> 658.974s (-0.25%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 1, 2023
@thomcc
Copy link
Member

thomcc commented Jul 1, 2023 •
edited
Loading

Looks good, glad to see a (cleaner) fix for that stdarch issue (hopefully)

@bors r+

@bors
Copy link
Contributor

bors commented Jul 1, 2023

📌 Commit 528f11c has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2023
@bors
Copy link
Contributor

bors commented Jul 1, 2023

⌛ Testing commit 528f11c with merge 6b06fdf...

@bors
Copy link
Contributor

bors commented Jul 1, 2023

☀️ Test successful - checks-actions
Approved by: thomcc
Pushing 6b06fdf to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 1, 2023
@bors bors merged commit 6b06fdf into rust-lang:master Jul 1, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jul 1, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6b06fdf): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.3% [1.3%, 1.3%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.3% [-3.6%, -1.0%] 3
Improvements ✅
(secondary)		 -2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) -1.4% [-3.6%, 1.3%] 4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.0% [0.5%, 1.7%] 3
Regressions ❌
(secondary)		 2.7% [2.7%, 2.7%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.0% [0.5%, 1.7%] 3

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.0% [0.0%, 0.0%] 5
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.1% [-0.2%, -0.0%] 12
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.1% [-0.2%, 0.0%] 17

Bootstrap: 661.53s -> 662.02s (0.07%)

@lu-zero lu-zero deleted the intrinsics-inline branch July 1, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
7 participants
@lu-zero @rustbot @Amanieu @bors @rust-timer @lqd @thomcc